Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: require password verification for email updates #5780

Merged
merged 7 commits into from
Apr 26, 2024
Merged

feat: require password verification for email updates #5780

merged 7 commits into from
Apr 26, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Apr 23, 2024

What type of PR is this?

/kind feature
/milestone 2.15.x
/area core

What this PR does / why we need it:

增加了在用户尝试更新邮箱地址时进行密码验证的步骤。此举提高了安全性，确保邮箱修改操作由经过身份验证的用户执行。

Which issue(s) this PR fixes:

Fixes #5750

Does this PR introduce a user-facing change?

更新邮箱地址时需进行密码验证

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 23, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 23, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen April 23, 2024 09:06
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Apr 23, 2024
@guqing guqing marked this pull request as ready for review April 25, 2024 08:11
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from lan-yonghui April 25, 2024 08:11
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (5fdf6c0) to head (0433eac).
Report is 143 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5780      +/-   ##
============================================
- Coverage     56.91%   56.54%   -0.38%     
- Complexity     3319     3375      +56     
============================================
  Files           587      605      +18     
  Lines         18968    19883     +915     
  Branches       1401     1371      -30     
============================================
+ Hits          10795    11242     +447     
- Misses         7594     8069     +475     
+ Partials        579      572       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruibaby
ruibaby reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@LIlGG
Copy link
Member

LIlGG commented Apr 26, 2024

image

简体中文的多语言下，返回的提示是英文的

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@guqing
Copy link
Member Author

guqing commented Apr 26, 2024

简体中文的多语言下，返回的提示是英文的

修复了

LIlGG
LIlGG reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ruibaby
ruibaby approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 1ade849 into halo-dev:main Apr 26, 2024
8 checks passed
@guqing guqing deleted the feature/5750 branch April 26, 2024 10:07
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LIlGG LIlGG LIlGG left review comments

@ruibaby ruibaby ruibaby approved these changes

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

@wan92hen wan92hen Awaiting requested review from wan92hen

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@ruibaby ruibaby

@LIlGG LIlGG

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

用户编辑资料里的问题
3 participants
@guqing @LIlGG @ruibaby